[PATCH] D128029: [AArch64] Add target feature "all"

Fri Jun 17 09:26:41 PDT 2022

nickdesaulniers added a comment.

Honestly, I think this feature list should just exist in the disassembler.  Is this generally useful when building code? I don't think so; it's meaning and ABI will change over time as more extensions are added to the architecture.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:558-566

+// Only available to disassemblers.
+def FeatureAll
+    : SubtargetFeature<"all", "IsAll", "true", "Enable all instructions", [
+      HasV9_3aOps, FeatureCrypto, FeatureETE, FeatureFP16FML, FeatureMTE,
+      FeatureMatMulFP32, FeatureMatMulFP64, FeaturePerfMon, FeatureRandGen,
+      FeatureRME, FeatureSMEF64, FeatureSMEI64, FeatureSPE, FeatureSVE2AES,
----------------
c-rhodes wrote:
> I think this will introduce a bit of a maintenance burden and I can see new features being missed, could this be generated by tablegen?
Or perhaps an assertion somewhere if the possible feature list grows to alert this needs to be updated?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128029/new/

https://reviews.llvm.org/D128029