[PATCH] D127915: [windows][support] Improve backtrace emitted in crash report without llvm-symbolizer

Fri Jun 17 07:22:42 PDT 2022

aaron.ballman added inline comments.

================
Comment at: llvm/lib/Support/Windows/Signals.inc:340

 // Print the parameters.  Assume there are four.
 #if defined(_M_X64) || defined(_M_ARM64)
----------------
bd1976llvm wrote:
> rnk wrote:
> > I propose we scrap this parameter printing. I've never found it useful. It's a bunch of hex noise that makes the crash report look scary. My understanding is that doesn't work well on win64, since it assumes parameters are homed into the shadow stack space, which Clang doesn't generally do.
> Yes. Nice suggestion. We recently debugged out a horrible close-to-impossible-to-reproduce issue where this backtrace information was all we had available. I'll ask tomorrow whether anyone made use of these parameters and get back to you...
I think the stack traces we print out are basically just there for the call stack alone -- in order to do any real debugging of the situation, I've found I've needed to go to the minidump anyway (https://reviews.llvm.org/D18216). I'd be fine dropping the parameter information to reduce the amount of noise in the crash report.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127915/new/

https://reviews.llvm.org/D127915