[PATCH] D125777: [llvm-dva] 02 - Driver and documentation

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:43
+public:
+  bool isValidIndex(size_t Index) { return Index != BadIndex; }
+
----------------
psamolysov wrote:
> 
Added `const`.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:48
+  // strings.
+  size_t getSize() { return Entries.size() - 1; }
+
----------------
psamolysov wrote:
> 
Added `const`.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:51
+  // Return the index for the specified key, otherwise 'BadIndex'.
+  size_t findIndex(StringRef Key) {
+    TableType::const_iterator Iter = StringTable.find(Key);
----------------
psamolysov wrote:
> 
Added `const`.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:71
+  // Given the index, return its corresponding string.
+  StringRef getString(size_t Index) {
+    assert(Index < Entries.size() && "Invalid string pool index.");
----------------
psamolysov wrote:
> 
Added `const`.


================
Comment at: llvm/lib/DebugInfo/LogicalView/LLVMBuild.txt:22
+required_libraries = Object Support DebugInfoDWARF DebugInfoCodeView DebugInfoPDB
\ No newline at end of file

----------------
psamolysov wrote:
> An empty line should be added at EOF
Added empty line.


================
Comment at: llvm/tools/llvm-dva/Options.cpp:83
+           clEnumValN(LVAttributeKind::Format, "format",
+                      "Objet file format name."),
+           clEnumValN(LVAttributeKind::Gaps, "gaps",
----------------
psamolysov wrote:
> 
Fixed typo.


================
Comment at: llvm/tools/llvm-dva/Options.cpp:249
+           clEnumValN(LVReportKind::Children, "children",
+                      "Selected elements are displayed in a tree View "
+                      "(Include children)"),
----------------
psamolysov wrote:
> 
Changed to lowercase.


================
Comment at: llvm/tools/llvm-dva/Options.cpp:257
+           clEnumValN(LVReportKind::View, "view",
+                      "Selected elements are displayed in a tree View "
+                      "(Include parents and children.")));
----------------
psamolysov wrote:
> 
Changed to lowercase.


================
Comment at: llvm/tools/llvm-dva/llvm-dva.cpp:9
+//
+// This program is a utility that display the logical view for the debug
+// information.
----------------
psamolysov wrote:
> 
Fixed typo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125777/new/

https://reviews.llvm.org/D125777