[PATCH] D127964: [DCE] Eliminate no-op atan and atan2 calls

Mohammed Nurul Hoque via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 04:01:42 PDT 2022


mohammed-nurulhoque added a comment.

In D127964#3591112 <https://reviews.llvm.org/D127964#3591112>, @sepavloff wrote:

> The opengroup specification (https://pubs.opengroup.org/onlinepubs/9699919799/functions/atan.html) states:
>
>   If x is subnormal, a range error may occur
>
> It does not state that `error shall occur`, which means this behavior is optional. So constant evaluation hardly needs changes.

Yes. But before this patch, it doesn't consider any atan* call as No-Op, which means it's assuming all atan* as potentially failing.
This patch strictly limits the cases where an error might be expected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127964/new/

https://reviews.llvm.org/D127964



More information about the llvm-commits mailing list