[PATCH] D51829: [MachineInstr] In addRegisterKilled and addRegisterDead, don't remove operands from inline assembly instructions if they have an associated flag operand.
Malhar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 17 02:57:09 PDT 2022
malharJ added a comment.
Herald added subscribers: jsji, StephenFan, pengfei.
Herald added projects: LLVM, All.
The added condition
findInlineAsmFlagIdx(OpIdx) < 0))
avoids removing the Machine operand altogether (if there exists a corresponding inline asm flag),
was there any reason why the inline asm flag was not updated instead ?
ie. the code could still remove the machine operand but update the asm flag to reflect that (there is now one less operand) ?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D51829/new/
https://reviews.llvm.org/D51829
More information about the llvm-commits
mailing list