[PATCH] D128029: [AArch64] Add target feature "all"

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 01:06:26 PDT 2022


c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:558-566
 
+// Only available to disassemblers.
+def FeatureAll
+    : SubtargetFeature<"all", "IsAll", "true", "Enable all instructions", [
+      HasV9_3aOps, FeatureCrypto, FeatureETE, FeatureFP16FML, FeatureMTE,
+      FeatureMatMulFP32, FeatureMatMulFP64, FeaturePerfMon, FeatureRandGen,
+      FeatureRME, FeatureSMEF64, FeatureSMEI64, FeatureSPE, FeatureSVE2AES,
----------------
I think this will introduce a bit of a maintenance burden and I can see new features being missed, could this be generated by tablegen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128029/new/

https://reviews.llvm.org/D128029



More information about the llvm-commits mailing list