[PATCH] D124686: [Symbolize] Parser for log symbolizer markup.

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

LGTM thanks for the updates. I spotted what looked like one comment update for the change to Node, but that can easily be fixed up if needed.



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/Markup.h:34
+/// detected, then the control code will be the entirety of the Text field, and
+/// any surrounding text will be reported as preceding and following elements.
+struct MarkupNode {
----------------
I think `and following elements.` could be `and following nodes`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124686/new/

https://reviews.llvm.org/D124686