[PATCH] D127447: [RISCV] Cost model for scalable reductions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 17 00:10:26 PDT 2022


craig.topper added a comment.

In D127447#3590942 <https://reviews.llvm.org/D127447#3590942>, @liaolucy wrote:

> Don't we need to qualify Opcode?
>
> D126372 <https://reviews.llvm.org/D126372>,  I tried to implement a preliminary support, referring to other architectures limiting some opcode

Isn't the opcode checked on line 356?

  if (ISD != ISD::ADD && ISD != ISD::OR && ISD != ISD::XOR && ISD != ISD::AND &&
        ISD != ISD::FADD)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127447/new/

https://reviews.llvm.org/D127447



More information about the llvm-commits mailing list