[PATCH] D128020: [lld-macho] Fix parsing of $ld$ symbols with $ in them

[Keith Smiley via Phabricator via llvm-commits]

keith added a comment.

In D128020#3591012 <https://reviews.llvm.org/D128020#3591012>, @thakis wrote:

> The rsplit() is correct. I don't think the assert adds a ton of value.

no strong pref, i just figure this format shouldn't ever really change so it might be safer this way to avoid future breakages.

> Not sure it makes sense to land this without the rest of previous + sym handling as it can't be tested before then.
>
> I have half a patch for that locally, so maybe just wait a few days?

yea sounds fine, i just wanted to upload this asap in case someone did want to look into that issue before i did so they wouldn't have to re-fix this bug


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128020/new/

https://reviews.llvm.org/D128020