[PATCH] D128020: [lld-macho] Fix parsing of $ld$ symbols with $ in them

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 20:42:36 PDT 2022


thakis added a comment.

The rsplit() is correct. I don't think the assert adds a ton of value.

Not sure it makes sense to land this without the rest of previous + sym handling as it can't be tested before then.

I have half a patch for that locally, so maybe just wait a few days?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128020/new/

https://reviews.llvm.org/D128020



More information about the llvm-commits mailing list