[PATCH] D127950: [SimplifyCFG] Check isSafeToSpeculativelyExecute before computeSpeculationCost

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 19:10:31 PDT 2022


bcl5980 abandoned this revision.
bcl5980 added a comment.

In D127950#3589103 <https://reviews.llvm.org/D127950#3589103>, @nikic wrote:

> @bcl5980 Conceptually, yes., but I believe your specific patch does not handle `sdiv (i64 EXPR, i64 -1)` correctly. We also only need this for the signed case.

@nikic, Thanks for the explain. As I have little knowledge for this part can you help to fix the issue? I will abandon this change. Sorry for the disturbance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127950/new/

https://reviews.llvm.org/D127950



More information about the llvm-commits mailing list