[PATCH] D128005: [SelectionDAG] Don't apply MinRCSize constraint in InstrEmitter::AddRegisterOperand for IMPLICIT_DEF sources.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 14:56:34 PDT 2022


arsenm added a comment.

In D128005#3590458 <https://reviews.llvm.org/D128005#3590458>, @arsenm wrote:

> In D128005#3590452 <https://reviews.llvm.org/D128005#3590452>, @reames wrote:
>
>> As a guess, I think this is a workaround for the fact that we can't spill to other register classes.
>
> But the allocator does look for shared common superclasses to copy to before spilling, so I don't understand this

I guess this doesn't happen for fast regalloc which breaks every normal assumption


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128005/new/

https://reviews.llvm.org/D128005



More information about the llvm-commits mailing list