[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 16 14:10:42 PDT 2022
rahmanl added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/bb-addr-map.test:75
+# V0-NEXT: Offset: 0xC
+# V1-NEXT: Offset: 0x1F
+# CHECK-NEXT: Size: 0xD
----------------
jhenderson wrote:
> For V1 output, I feel like it would be useful to have both the raw offset and the calculated offset printed. I'm not sure exactly what would be the best way of doing that though.
I think we should only care about the final calculated offset for verification. The raw offset is just an encoding technicality and should not be given much semantic importance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121346/new/
https://reviews.llvm.org/D121346
More information about the llvm-commits
mailing list