[PATCH] D125520: [TableGen][DirectX] generate DXIL operation table with TableGen.

Thu Jun 16 14:09:37 PDT 2022

hctim added a comment.

Hey, looks like this breaks with `-Werror`. Did a quick revert, PTAL and reland :).

https://lab.llvm.org/buildbot/#/builders/77/builds/18671

  FAILED: utils/TableGen/CMakeFiles/llvm-tblgen.dir/DXILEmitter.cpp.o 
  CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm_build64/utils/TableGen -I/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/utils/TableGen -I/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm_build64/include -I/var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT utils/TableGen/CMakeFiles/llvm-tblgen.dir/DXILEmitter.cpp.o -MF utils/TableGen/CMakeFiles/llvm-tblgen.dir/DXILEmitter.cpp.o.d -o utils/TableGen/CMakeFiles/llvm-tblgen.dir/DXILEmitter.cpp.o -c /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/utils/TableGen/DXILEmitter.cpp
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/utils/TableGen/DXILEmitter.cpp:279:13: error: unused variable 'PrevCategory' [-Werror,-Wunused-variable]
    StringRef PrevCategory = "";
              ^
  1 error generated.
  [828/4628] Building CXX object lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/AsmParser.cpp.o

================
Comment at: llvm/utils/TableGen/DXILEmitter.cpp:279
+  StringSet<> ClassSet;
+  StringRef PrevCategory = "";
+  for (auto &DXILOp : DXILOps) {
----------------
Unused variable here, broke the sanitizer build bots that build with `-Werror`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125520/new/

https://reviews.llvm.org/D125520