[PATCH] D127103: CodeGen: Split out MachineVerifier's liveness tracking
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 16 14:07:33 PDT 2022
MatzeB added a comment.
I didn't go into any detailed review here, but some top of the head thoughs:
- We already have `LiveIntervals` which was supposed to be good enough for everyone. I agree that there is no efficient API for querying every vreg live at a certain program point. But I'd feel more comfortable adding a convenience or caching layer for that on top of `LiveIntervals`...
- We already have a 2nd system `LiveVariables` (which we failed to actually deprecate enough to remove).
- This is adding a 3rd one, so I think it ought to have some better justification than "simplicity over speed".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127103/new/
https://reviews.llvm.org/D127103
More information about the llvm-commits
mailing list