[PATCH] D127990: [DirectX] add thread/group id DXIL operations.

[Xiang Li via Phabricator via llvm-commits]

python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsDXIL.td:15
+
+def int_dxil_ThreadId : Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoMem, IntrWillReturn]>;
+def int_dxil_GroupId : Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoMem, IntrWillReturn]>;
----------------
beanz wrote:
> python3kgae wrote:
> > beanz wrote:
> > > nit: by convention in LLVM intrinsics are generally lower-case `_` separated words.
> > Fixed.
> `_` separated, not camel case. `group_id` rather than `groupId` would be the convention.
Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127990/new/

https://reviews.llvm.org/D127990