[PATCH] D127342: [TargetTransformInfo] Added an option for the cache line size

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/lib/Analysis/TargetTransformInfo.cpp:35
+static cl::opt<unsigned> CacheLineSize(
+    "cache-line-size", cl::init(64), cl::Hidden,
+    cl::desc("Use this to override the target cache line size when "
----------------
Since we only use this when `getNumOccurrences() > 0`, the initialization to 64 isn't necessary or useful. I'd initialize it to 0 for consistency (and to avoid confusion) with the default implementation of  `getCacheLineSize`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127342/new/

https://reviews.llvm.org/D127342