[PATCH] D127959: [AMDGPU][NFC] Remove isConstantAddr

Liao Chunyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 05:58:28 PDT 2022


liaolucy created this revision.
liaolucy added a reviewer: rampitec.
Herald added subscribers: kosarev, jsilvanus, hsmhsm, foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: All.
liaolucy requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

fix isConstantAddr defined but not used


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127959

Files:
  llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp


Index: llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
+++ llvm/lib/Target/AMDGPU/AMDGPUPerfHintAnalysis.cpp
@@ -116,7 +116,6 @@
 
   bool isGlobalAddr(const Value *V) const;
   bool isLocalAddr(const Value *V) const;
-  bool isConstantAddr(const Value *V) const;
 };
 
 static std::pair<const Value *, const Type *> getMemoryInstrPtrAndType(
@@ -336,15 +335,6 @@
   return MAI;
 }
 
-bool AMDGPUPerfHint::isConstantAddr(const Value *V) const {
-  if (auto PT = dyn_cast<PointerType>(V->getType())) {
-    unsigned As = PT->getAddressSpace();
-    return As == AMDGPUAS::CONSTANT_ADDRESS ||
-           As == AMDGPUAS::CONSTANT_ADDRESS_32BIT;
-  }
-  return false;
-}
-
 bool AMDGPUPerfHint::MemAccessInfo::isLargeStride(
     MemAccessInfo &Reference) const {
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127959.437520.patch
Type: text/x-patch
Size: 887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220616/d732278f/attachment.bin>


More information about the llvm-commits mailing list