[PATCH] D127950: [SimplifyCFG] Check isSafeToSpeculativelyExecute before computeSpeculationCost

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 16 04:02:35 PDT 2022


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

I believe the real problem here is that canTrap() only checks for division by zero, but not division of SIGNED_MIN by -1, which also traps. This leads to an inconsistency between canTrap() and isSafeToSpeculativelyExecute().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127950/new/

https://reviews.llvm.org/D127950



More information about the llvm-commits mailing list