[PATCH] D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 15 23:49:26 PDT 2022
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5280
EVT NOutVT = TLI.getTypeToTransformTo(*DAG.getContext(), OutVT);
- assert(NOutVT.isVector() && "Type must be promoted to a vector type");
+ assert(NOutVT.isScalableVector() &&
+ "Type must be promoted to a scalable vector type");
----------------
Why this change? llvm.stepvector intrinsic works for fixed vectors.
================
Comment at: llvm/test/CodeGen/RISCV/rvv/vreductions-fp-vp.ll:318
-define double @vpreduce_ord_fadd_nxv3f64(double %s, <vscale x 4 x double> %v, <vscale x 4 x i1> %m, i32 zeroext %evl) {
+define double @vpreduce_ord_fadd_nxv3f64(double %s, <vscale x 3 x double> %v, <vscale x 3 x i1> %m, i32 zeroext %evl) {
; CHECK-LABEL: vpreduce_ord_fadd_nxv3f64:
----------------
The rest of this patch involve stepvector, but this doesn't. Unless I'm missing something this should be a different patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127939/new/
https://reviews.llvm.org/D127939
More information about the llvm-commits
mailing list