[PATCH] D127766: [InstCombine] Fold memcmp of constant arrays and variable size

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 23:23:12 PDT 2022


courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

In D127766#3587383 <https://reviews.llvm.org/D127766#3587383>, @msebor wrote:

> 



> I've left the loop as suggested but I expect to need to go back to something closer to the original in the `strncmp` followup.

SGTM, but let's do it when we get there :)



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:1004
   if (isKnownNonZero(Size, DL))
     annotateNonNullNoUndefBasedOnAccess(CI, 0);
 
----------------
Please run clang-format before pushing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127766/new/

https://reviews.llvm.org/D127766



More information about the llvm-commits mailing list