[PATCH] D127924: [BOLT] Resolve crash when optimizing Python

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 19:14:10 PDT 2022


Amir added a comment.

Please retitle the diff to state what is changed - e.g. "allow function fragments point to one jump table".

I like the summary, it explains the issue in a clear manner. Some nits:

- no need to explicitly mention python,
- I would rephrase 'next goal' and 'stretch goal' as potential or future improvements.
- please run a spell checker.



================
Comment at: bolt/test/X86/split-func-jump-table-fragment-bidirection.s:4
+# The fragment is only reachable through a jump table, so all functions must be
+# ignored.
+
----------------
Please updated the message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127924/new/

https://reviews.llvm.org/D127924



More information about the llvm-commits mailing list