[PATCH] D127815: [test][AlwaysInline]:Correct comment and file check for always-inline.ll

Wed Jun 15 17:34:06 PDT 2022

modimo added inline comments.

================
Comment at: llvm/test/Transforms/Inline/always-inline.ll:116
 define internal void @inner6(i32 %x) alwaysinline {
 ; CHECK-LABEL: @inner6(
 entry:
----------------
hoy wrote:
> iamarchit123 wrote:
> > hoy wrote:
> > > Should we have check like below after the label?
> > > 
> > > ```
> > > 
> > > ; CHECK: call void @inner6
> > > ```
> > Yes, that can be added but do you think the functionality that it will check gets already checked at line 131 and that is sufficient, or this CHECK will indeed check for something new?
> The check at line 131 is for a different function scope, i.e, `outer6`. Note that the check at line 130 signals that the checker is in `outer6` scope when it is there. I was thinking about adding a check inside the `inner6` scope. 
> 
> On the second thought, I might misunderstand the original author's intention, which may be to check `inner6` was not inlined into `outer6`. To that extent the current change is good. 
I think the intent behind the checks on inner functions is: if they are inlined, are they also successfully eliminated from IR? `; CHECK-NOT: @inner4(` for example. If that's correct, then agreed this can remain as is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127815/new/

https://reviews.llvm.org/D127815