[PATCH] D125519: [TableGen][DirectX] Add tableGen backend to generate map from llvm intrinsic to DXIL operation.
Xiang Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 15 17:24:53 PDT 2022
python3kgae marked an inline comment as done.
python3kgae added inline comments.
================
Comment at: llvm/utils/TableGen/DXILEmitter.cpp:196
+ OS << "\n";
+ OS << "static const SmallDenseMap<Intrinsic::ID, DXIL::OpCode> LowerMap = "
+ "{\n";
----------------
bogner wrote:
> Probably better done as a separate change, but is a SmallDenseMap really the best option here? We could probably just store this as an array of pairs and pre-sort it, then query it with std::lower_bound on the keys instead.
Tried to change to array. But find it hard to get intrinsic ID in tableGen for pre-sort.
Leave it for future change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125519/new/
https://reviews.llvm.org/D125519
More information about the llvm-commits
mailing list