[PATCH] D127906: [gn build] Allow use_ubsan=true on mac and unbreak use_asan and use_ubsan
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 15 16:34:03 PDT 2022
pcc added a subscriber: phosek.
pcc added inline comments.
================
Comment at: llvm/utils/gn/build/toolchain/BUILD.gn:256-257
current_cpu = "arm64"
+ use_asan = false
+ use_ubsan = false
}
----------------
pcc wrote:
> Can we add these lines to the `stage2_unix_toolchain` template instead, as I mentioned in D122862?
On the other review @phosek mentioned that `use_asan` ought to affect libc++ and so on.
That seems reasonable enough, but we might need to change the build a bit to make that work.
Maybe we can move the sanitizer flags into a default config, and have the sanitizers and builtins libraries subtract that from the config?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127906/new/
https://reviews.llvm.org/D127906
More information about the llvm-commits
mailing list