[PATCH] D127815: [test][AlwaysInline]:Correct comment and file check for always-inline.ll

Archit Saxena via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 16:12:20 PDT 2022


iamarchit123 added inline comments.


================
Comment at: llvm/test/Transforms/Inline/always-inline.ll:116
 define internal void @inner6(i32 %x) alwaysinline {
 ; CHECK-LABEL: @inner6(
 entry:
----------------
hoy wrote:
> Should we have check like below after the label?
> 
> ```
> 
> ; CHECK: call void @inner6
> ```
Yes, that can be added but do you think the functionality that it will check gets already checked at line 131 and that is sufficient, or this CHECK will indeed check for something new?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127815/new/

https://reviews.llvm.org/D127815



More information about the llvm-commits mailing list