[PATCH] D122862: gn build: Fix support for building the builtins for baremetal.

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D122862#3587325 <https://reviews.llvm.org/D122862#3587325>, @pcc wrote:

> I don't think I would expect the stage 2 runtimes to be built with a sanitizer even if `use_asan` is set. The sanitizer runtimes themselves don't support being built with sanitizers, and they might be compiled to depend on the builtins, which would create a circular dependency. So I think `use_asan` and such should only affect the stage 1 compiler. I think I would favor adding `use_asan = false` to the `stage2_unix_toolchain` template.

While it doesn't make sense to build compiler-rt with ASan, it's useful for other runtimes like libc++abi and libc++, so I'd like to avoid adding `use_asan = false` to the `stage2_unix_toolchain` template.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122862/new/

https://reviews.llvm.org/D122862