[PATCH] D127903: [InstCombine] Optimize test for same-sign of values

[Eric Gullufsen via Phabricator via llvm-commits]

emgullufsen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/same-sign-naive.ll:3
+
+define i1 @samesign(i32 %x, i32 %y) {
+; CHECK-LABEL: @samesign(
----------------
spatel wrote:
> You can tack more tests on to the end of related tests in "and-or-icmps.ll". 
> You can also get an idea about how to vary tests to get better coverage by looking at existing tests.
> One common variation to test (and code for): what happens if the intermediate values have other uses?
Ah I see - roger that - I'll have more tests in update patch - thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127903/new/

https://reviews.llvm.org/D127903