[PATCH] D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5).

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D56593#3586718 <https://reviews.llvm.org/D56593#3586718>, @xbolva00 wrote:

> Seems fine as well.
>
> Maybe there should be a RFC at Discourse ? ..

Looks to be headed that way. On the __memcmpeq patches review there is a bit more discussion. If no resolution
soon then yeah an RFC.

In D56593#3586673 <https://reviews.llvm.org/D56593#3586673>, @jyknight wrote:

> In D56593#3585700 <https://reviews.llvm.org/D56593#3585700>, @goldstein.w.n wrote:
>
>> I guess we can go with the flag being used by gcc: `-fextra-libc-function=__memcmpeq`.
>
> Can't that just be spelled `-fbuiltin-__memcmpeq`?

GCC isn't going with `-fextra-libc-function=...`. They are going to just do a system header check.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56593/new/

https://reviews.llvm.org/D56593