[PATCH] D122862: gn build: Fix support for building the builtins for baremetal.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 14:30:04 PDT 2022


thakis added a comment.

Which one is the right fix? Should we allow asan for baremetal? Or should we force off asan for the baremetal toolchain? (Diff for 2nd option would be

  diff --git a/llvm/utils/gn/build/toolchain/BUILD.gn b/llvm/utils/gn/build/toolchain/BUILD.gn
  index 29da00c29fca..6bf5febf3d39 100644
  --- a/llvm/utils/gn/build/toolchain/BUILD.gn
  +++ b/llvm/utils/gn/build/toolchain/BUILD.gn
  @@ -253,6 +253,7 @@ stage2_unix_toolchain("stage2_baremetal_aarch64") {
     toolchain_args = {
       current_os = "baremetal"
       current_cpu = "arm64"
  +    use_asan = false
     }
   }


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122862/new/

https://reviews.llvm.org/D122862



More information about the llvm-commits mailing list