[PATCH] D127899: [inline] Don't inline call sites in unreachable basic blocks

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 12:42:12 PDT 2022


mtrofin created this revision.
mtrofin added reviewers: kazu, Northbadge.
Herald added a subscriber: hiraditya.
Herald added a project: All.
mtrofin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This requires DominatorTree be updated, which we do in the ml inliner
case, but not in the default case, and the cost of doing so is
noticeable to compile time for the latter[1]. So the patch only affects
the ML inliner.

[1] https://llvm-compile-time-tracker.com/compare.php?from=9fc0aa45e3312944431ba7e1ca0cec99c613992b&to=7af461b1ce0d9138211ef5f883f35d5b9ddf47be&stat=wall-time


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127899

Files:
  llvm/include/llvm/Analysis/MLInlineAdvisor.h
  llvm/lib/Analysis/MLInlineAdvisor.cpp
  llvm/test/Transforms/Inline/ML/skip-unreachable.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127899.437300.patch
Type: text/x-patch
Size: 3461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220615/40977fc2/attachment.bin>


More information about the llvm-commits mailing list