[PATCH] D127753: [lld-macho] Group undefined symbol diagnostics by symbol

[Kirill Stoimenov via Phabricator via llvm-commits]

kstoimenov added a comment.

This might be breaking sanitizer builds: https://lab.llvm.org/buildbot/#/builders/5/builds/24787/steps/19/logs/stdio

Could you please take a look? 
Thanks!

  FAIL: lld :: MachO/arch-multiple.s (66137 of 66440)
  ******************** TEST 'lld :: MachO/arch-multiple.s' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/bin/llvm-mc -filetype=obj -triple=x86_64-apple-macos -o /b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/tools/lld/test/MachO/Output/arch-multiple.s.tmp.o /b/sanitizer-x86_64-linux-fast/build/llvm-project/lld/test/MachO/arch-multiple.s
  : 'RUN: at line 4';   not ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /b/sanitizer-x86_64-linux-fast/build/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk -fatal_warnings -o /b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/tools/lld/test/MachO/Output/arch-multiple.s.tmp.out -arch_multiple /b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/tools/lld/test/MachO/Output/arch-multiple.s.tmp.o 2>&1 | /b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/lld/test/MachO/arch-multiple.s
  --
  Exit Code: 1
  Command Output (stderr):
  --
  /b/sanitizer-x86_64-linux-fast/build/llvm-project/lld/test/MachO/arch-multiple.s:6:10: error: CHECK: expected string not found in input
  # CHECK: error: undefined symbol for arch x86_64: _foo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127753/new/

https://reviews.llvm.org/D127753