[PATCH] D127787: [TableGen][X86] Emit memory operand size table

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 10:53:52 PDT 2022


Amir marked 2 inline comments as done.
Amir added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:397
   let OperandType = "OPERAND_MEMORY";
+  int Size = size;
 }
----------------
skan wrote:
> Could you also simply the function `getMemOperandSize` in  X86RecognizableInstr.cpp in this patch? You can return value of `Size` now.
Done. I'm not 100% sure it's an equivalent replacement – i.e. if all Operand's that have `ParserMatchClass->Name = Mem*` are actually X86MemOperand's. But the check-llvm test passed locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127787/new/

https://reviews.llvm.org/D127787



More information about the llvm-commits mailing list