[PATCH] D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

In D127461#3586144 <https://reviews.llvm.org/D127461#3586144>, @jyknight wrote:

> In D127461#3586121 <https://reviews.llvm.org/D127461#3586121>, @goldstein.w.n wrote:
>
>> Wouldn't that almost definitionally only work if the file was being compiled statically? Otherwise you would
>> run into the issue that compiling on a system with glibc >= 2.35 produce an executable that wouldn't work
>> on a system with glibc < 2.35
>
> There is absolutely no expectation of compatibility in that direction. A binary compiled against version X of glibc can run against any glibc version Y, where Y >= X -- but NOT the other way around.

Okay, so how about the same system header check approach as GCC is planning to go with?

Or do you want to limit this to just GLIBC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127461/new/

https://reviews.llvm.org/D127461