[llvm] b0c51f0 - [memprof] Update the test comments to include -Wl, -no-pie

Snehasish Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 09:49:25 PDT 2022


Author: Snehasish Kumar
Date: 2022-06-15T16:49:19Z
New Revision: b0c51f00ae6853b9fb1591390456c1119f723387

URL: https://github.com/llvm/llvm-project/commit/b0c51f00ae6853b9fb1591390456c1119f723387
DIFF: https://github.com/llvm/llvm-project/commit/b0c51f00ae6853b9fb1591390456c1119f723387.diff

LOG: [memprof] Update the test comments to include -Wl,-no-pie

Until we have symbolization for position independent code lets update
this documentation since clang now defaults to position independent
code.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D127808

Added: 
    

Modified: 
    llvm/test/tools/llvm-profdata/memprof-basic.test
    llvm/test/tools/llvm-profdata/memprof-inline.test
    llvm/test/tools/llvm-profdata/memprof-merge.test
    llvm/test/tools/llvm-profdata/memprof-multi.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-profdata/memprof-basic.test b/llvm/test/tools/llvm-profdata/memprof-basic.test
index b0086fbc7ea32..be04427ae6083 100644
--- a/llvm/test/tools/llvm-profdata/memprof-basic.test
+++ b/llvm/test/tools/llvm-profdata/memprof-basic.test
@@ -26,9 +26,10 @@ recorded.
 ```
 clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
       -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-      -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+      -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+      source.c -o basic.memprofexe
 
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
 ```
 
 RUN: llvm-profdata show --memory %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o - | FileCheck %s

diff  --git a/llvm/test/tools/llvm-profdata/memprof-inline.test b/llvm/test/tools/llvm-profdata/memprof-inline.test
index a08af1d4873ca..aaa7907d57f63 100644
--- a/llvm/test/tools/llvm-profdata/memprof-inline.test
+++ b/llvm/test/tools/llvm-profdata/memprof-inline.test
@@ -30,9 +30,10 @@ Compile and run with the following commands:
 ```
 bin/clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
           -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-          -fno-optimize-sibling-calls -m64 -Wl,-build-id inline.c -o memprof-inline.exe
+          -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+          inline.c -o inline.memprofexe
 
-env MEMPROF_OPTIONS=log_path=stdout ./memprof-inline.exe > inline.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./inline.memprofexe > inline.memprofraw
 ```
 
 RUN: llvm-profdata show --memory %p/Inputs/inline.memprofraw --profiled-binary %p/Inputs/inline.memprofexe | FileCheck %s

diff  --git a/llvm/test/tools/llvm-profdata/memprof-merge.test b/llvm/test/tools/llvm-profdata/memprof-merge.test
index b11459f237ca5..e9e836abb8e9c 100644
--- a/llvm/test/tools/llvm-profdata/memprof-merge.test
+++ b/llvm/test/tools/llvm-profdata/memprof-merge.test
@@ -28,9 +28,10 @@ mv *.profraw basic.profraw
 # Collect memprof profile.
 clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
       -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-      -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o basic.memprofexe
+      -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+      source.c -o basic.memprofexe
 
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > basic.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./basic.memprofexe > basic.memprofraw
 ```
 
 RUN: llvm-profdata merge %p/Inputs/basic.profraw %p/Inputs/basic.memprofraw --profiled-binary %p/Inputs/basic.memprofexe -o %t.prof

diff  --git a/llvm/test/tools/llvm-profdata/memprof-multi.test b/llvm/test/tools/llvm-profdata/memprof-multi.test
index 7463b13299513..08f6a0daebd84 100644
--- a/llvm/test/tools/llvm-profdata/memprof-multi.test
+++ b/llvm/test/tools/llvm-profdata/memprof-multi.test
@@ -28,9 +28,10 @@ recorded.
 ```
 clang -fuse-ld=lld -Wl,--no-rosegment -gmlt -fdebug-info-for-profiling \
       -fmemory-profile -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer \
-      -fno-optimize-sibling-calls -m64 -Wl,-build-id source.c -o multi.memprofexe
+      -fno-optimize-sibling-calls -m64 -Wl,-build-id -Wl,-no-pie \
+      source.c -o multi.memprofexe
 
-env MEMPROF_OPTIONS=log_path=stdout ./rawprofile.out > multi.memprofraw
+env MEMPROF_OPTIONS=log_path=stdout ./multi.memprofexe > multi.memprofraw
 ```
 
 RUN: llvm-profdata show --memory %p/Inputs/multi.memprofraw --profiled-binary %p/Inputs/multi.memprofexe -o - | FileCheck %s


        


More information about the llvm-commits mailing list