[PATCH] D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 09:44:38 PDT 2022


goldstein.w.n added a comment.

In D127461#3585676 <https://reviews.llvm.org/D127461#3585676>, @xbolva00 wrote:

> Clang side should match gcc’s https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596335.html

It seems GCC may not end up sticking with `-fextra-libc-function=`. They seem to want to do this
just with just a check for if `__memcmpeq` is declared.

Assuming GCC does stick with `-fextra-libc-function=` do you think llvm's side should keep the 
`--with-builtin-memcmpeq` and clang should enable that if it sees '__memcmpeq' in 
`-fextra-libc-function=*` or it should redirect all extra functions to llvm and let llvm handle them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127461/new/

https://reviews.llvm.org/D127461



More information about the llvm-commits mailing list