[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

Wed Jun 15 08:23:22 PDT 2022

cor3ntin added a comment.

In D123064#3585074 <https://reviews.llvm.org/D123064#3585074>, @aaron.ballman wrote:

> I had a discussion about the license file on IRC (but not with @tstellar) and the thinking there was: add the license file. It seems to either be required or would be harmless to add. So if we don't hear something different from @tstellar on this, I think you should add the contents of https://www.unicode.org/license.txt to the top of the generated content for `UnicodeNameToCodepointGenerated.cpp` so that the license information stays with the derived data to which it applies.

After more chat with Aaron, I added the license in the generated file, in addition of the llvm license header so there is no confusion, This seems to be consistent with other third party files like the regex support files.
In the long run, i think we should consolidate all the tools handling unicode data in a consistent place, at which point we could commit a license file there, along with the data files themselves.

================
Comment at: clang/lib/Lex/LiteralSupport.cpp:509-511
+    if (std::max(Distance, Match.Distance) -
+            std::min(Distance, Match.Distance) >
+        3)
----------------
aaron.ballman wrote:
> 
They are unsigned so that wouldn't work!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123064/new/

https://reviews.llvm.org/D123064