[PATCH] D127848: [CodeGen] Fix the bug of machine sink

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 15 08:03:57 PDT 2022


shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

LGTM with one nit. Thanks for fixing this.



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:802
     // Ignore non-register operands.
     if (!MO.isReg())
       continue;
----------------
Maybe better to exclude the undef case at the very beginning?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127848/new/

https://reviews.llvm.org/D127848



More information about the llvm-commits mailing list