[PATCH] D127031: [CSSPGO][llvm-profgen] Reimplement SampleContextTracker using context trie
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 14 23:42:40 PDT 2022
wlei added inline comments.
================
Comment at: llvm/include/llvm/Transforms/IPO/SampleContextTracker.h:95
// deterministically.
- using ContextSamplesTy = std::set<FunctionSamples *, ProfileComparer>;
+ using ContextSamplesTy = SmallVector<FunctionSamples *, 16>;
----------------
hoy wrote:
> Wondering if 16 can be larger than needed in general. Since we are aiming for mem savings, maybe a smaller value is better? Or just use std::vector. Shouldn't be a big deal though.
Sounds good, used std::vector
================
Comment at: llvm/include/llvm/Transforms/IPO/SampleContextTracker.h:150
+ // Get a context string from root to current node.
+ std::string getContextString(const FunctionSamples &FSamples) const;
+ std::string getContextString(ContextTrieNode *Node) const;
----------------
hoy wrote:
> Make this debug-only?
Done, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127031/new/
https://reviews.llvm.org/D127031
More information about the llvm-commits
mailing list