[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

[Fazlay Rabbi via Phabricator via llvm-commits]

mdfazlay added inline comments.


================
Comment at: clang/include/clang-c/Index.h:2641
    */
-  CXCursor_TranslationUnit = 300,
+  CXCursor_TranslationUnit = 350,
 
----------------
ABataev wrote:
> Does this change affect anything else in the compiler?
We had to add and keep the CXCursor_OMPParallelMaskedDirective with other OpenMP directives. I believe it doesn't affect anything else in the compiler. We have made necessary changes in "clang/bindings/python/clang/cindex.py" to reflect the new value of CXCursor_TranslationUnit.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:2315
+///
+class OMPParallelMaskedDirective : public OMPExecutableDirective {
+  friend class ASTStmtReader;
----------------
ABataev wrote:
> `final`
Added in the new diff.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127454/new/

https://reviews.llvm.org/D127454