[PATCH] D127699: [InstCombine] Don't slice up PHIs when pred BB has catchswitch

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 16:44:38 PDT 2022


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp:1128
+    for (auto *Pred : PN->blocks())
+      if (isa<CatchSwitchInst>(Pred->getFirstNonPHI()))
+        return nullptr;
----------------
nikic wrote:
> The correct way to check this is whether `getFirstInsertionPt()` is `end()`.
Done in D127810.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127699/new/

https://reviews.llvm.org/D127699



More information about the llvm-commits mailing list