[PATCH] D127084: [MCA] Allow mca::Instruction-s to be recycled and reused

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/MCA/InstrBuilder.cpp:542-544
+InstrBuilder::createInstrDescImpl(const MCInst &MCI, bool &StaticDesc) {
   assert(STI.getSchedModel().hasInstrSchedModel() &&
          "Itineraries are not yet supported!");
----------------
andreadb wrote:
> I wonder if instead we should add a bitfield `bool IsRecyclable : 1` to `struct InstrDesc`.
> 
> By default, it would be set to false.
> 
> That way, you don't need to change these signatures, and you can still retrieve that information automatically. It might make the rest of the logic a bit more readable/self documenting.
yeah that definitely sounds more elegant


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127084/new/

https://reviews.llvm.org/D127084