[PATCH] D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 12:39:34 PDT 2022


kzhuravl added a comment.

In D127768#3582710 <https://reviews.llvm.org/D127768#3582710>, @rampitec wrote:

> In D127768#3582672 <https://reviews.llvm.org/D127768#3582672>, @kzhuravl wrote:
>
>> In D127768#3582616 <https://reviews.llvm.org/D127768#3582616>, @rampitec wrote:
>>
>>> Why not to remove original v_cmp instead? It should have no other uses.
>>
>> Original v_cmp_eq_u32 got removed in favor of v_cmpx_eq_u32. v_cmp_ne_u32 is left as is.
>
> OK, I see. That's another instruction in between kills it..
>
> What if src1 is not register?

Fixed and added test for the non register case. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127768/new/

https://reviews.llvm.org/D127768



More information about the llvm-commits mailing list