[PATCH] D126835: Round up zero-sized symbols to 1 byte in `.debug_aranges` (without breaking other logic).

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added a comment.

In D126835#3579779 <https://reviews.llvm.org/D126835#3579779>, @dblaikie wrote:

> In D126835#3577753 <https://reviews.llvm.org/D126835#3577753>, @hans wrote:
>
>> When trying this on Chromium (in the context of https://crbug.com/1335630) we hit a densemap assert in llvm::DwarfDebug::emitDebugARanges()
>> See the attached reproducer.
>>
>> F23428761: string_piece_unittest-c72fb0.sh <https://reviews.llvm.org/F23428761>
>>
>> F23428765: string_piece_unittest-c72fb0.cpp <https://reviews.llvm.org/F23428765>
>
> Thanks for the reproducer, @hansw - sounds worth addressing before this moves forward.
>
> (I'm still sort of feeling like we should fix the underlying entities to be non-zero length always (even if they're zero length at the language level - they can still be non-zero length as an implementation detail providing unique addresses))

Doesn't it rely on various feeders into llvm doing the right thing, or can this be done in some kind of language agnostic way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126835/new/

https://reviews.llvm.org/D126835