[PATCH] D126089: [WPD] Try harder to find assumes through phis

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D126089#3582321 <https://reviews.llvm.org/D126089#3582321>, @pcc wrote:

> In D126089#3582227 <https://reviews.llvm.org/D126089#3582227>, @aeubanks wrote:
>
>> is this patch ok to submit at least as a short term workaround?
>
> Chrome already has a short-term workaround, which is to disable opaque pointers, right? I think you can use that until the proper fix is developed.

As noted, I'm really not convinced that we cannot hit this issue for hidden visibility patches.

However, another reason to submit this particular patch is that it is merely enabling WPD in additional cases, when there is a phi between the type test and assume, by recognizing more assumes. I would imagine we will still have cases like that even for hidden visibility classes, or with your proposed fix to use a new TBD intrinsic that is converted to an llvm.type.test in the case of --lto-whole-program-visibility, right? So in either case this seems to me to be an improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126089/new/

https://reviews.llvm.org/D126089