[PATCH] D127719: [X86][NFC] Use mnemonic tables in validateInstruction 4/4

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 10:15:13 PDT 2022


Amir marked an inline comment as done.
Amir added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3843
   unsigned Opcode = Inst.getOpcode();
+  const MCInstrDesc &MCID = MII.get(Opcode);
   if (isVFCMADDCPH(Opcode) || isVFCMADDCSH(Opcode) ||
----------------
craig.topper wrote:
> Looking at the later uses, should this be `uint64_t TSFlags = MII.get(Opcode).TSFlags;`? It doesn't look like any other fields are used.
Agree. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127719/new/

https://reviews.llvm.org/D127719



More information about the llvm-commits mailing list