[PATCH] D127717: [X86][NFC] Use mnemonic tables in validateInstruction 2/4

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 09:42:20 PDT 2022


Amir added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3850
                                               "distinct from source registers");
+  } else if (isVFCMULCPH(Opcode) || isVFCMULCSH(Opcode) || isVFMULCPH(Opcode)) {
+    unsigned Dest = Inst.getOperand(0).getReg();
----------------
craig.topper wrote:
> What about VFMULCSH?
Thanks! Lost it indeed, which caused one test failure (LLVM.MC/X86::avx512fp16-complex-fma.s). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127717/new/

https://reviews.llvm.org/D127717



More information about the llvm-commits mailing list