[PATCH] D127753: [lld-macho] Group undefined symbol diagnostics by symbol

[Daniel Bertalan via Phabricator via llvm-commits]

BertalanD created this revision.
BertalanD added reviewers: int3, thakis, lld-macho.
Herald added projects: lld-macho, All.
BertalanD requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ld64.lld used to print the "undefined symbol" line for each reference to
an undefined symbol previously:

  ld64.lld: error: undefined symbol _foo
  >>> referenced by /path/to/bar.o:(symbol _baz+0x0)
  
  ld64.lld: error: undefined symbol _foo
  >>> referenced by /path/to/bar.o:(symbol _quux+0x1)

Now they are deduplicated:

  ld64.lld: error: undefined symbol _foo
  >>> referenced by /path/to/bar.o:(symbol _baz+0x0)
  >>> referenced by /path/to/bar.o:(symbol _quux+0x1)

As with the other lld ports, only the first 3 references are printed.

Please commit this diff with the following author info:
Daniel Bertalan <dani at danielbertalan.dev>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127753

Files:
  lld/MachO/SymbolTable.cpp
  lld/MachO/SymbolTable.h
  lld/MachO/Writer.cpp
  lld/test/MachO/invalid/undef-multi.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127753.436799.patch
Type: text/x-patch
Size: 5115 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220614/e366f585/attachment.bin>