[PATCH] D127414: [AArch64][SME] Add SME read/write intrinsics that map to the mova instruction

[David Sherwood via Phabricator via llvm-commits]

david-arm marked 6 inline comments as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:704-705
+                                     nxv16i8, nxv16i1, sme_elm_idx0_0, imm0_15,
+                                     !if(is_col, int_aarch64_sme_write_vert,
+                                                 int_aarch64_sme_write_horiz),
+                                     tileslice8>;
----------------
c-rhodes wrote:
> this is repeated a bunch how about doing:
> 
> ```  defvar op = !if(is_col, int_aarch64_sme_write_vert,
>                           int_aarch64_sme_write_horiz);```
> 
> above and replacing uses with op to clean it up a bit?
Great suggestion @c-rhodes!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127414/new/

https://reviews.llvm.org/D127414