[PATCH] D127696: [lld-macho] Print the name of functions containing undefined references

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 14 05:07:16 PDT 2022


thakis added a comment.

In D127696#3581100 <https://reviews.llvm.org/D127696#3581100>, @int3 wrote:

>> Should we omit it too, at least for undefined symbol diags?
>
> IMO we are strictly providing more useful info here so I think it makes more sense for us to keep it this way and maybe have the other ports changed to match at some point

What's useful about an offset about a function?

I think for almost everyone, the offset is at best noise they'll ignore or at worst something that confuses them.

And even for people who know what it means and can read assembly, what's the added value of knowing which offset in a function has the reference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127696/new/

https://reviews.llvm.org/D127696



More information about the llvm-commits mailing list